The Username, Password and Initial Volume UI elements seem to be missing on my Spotify Connect / volspotconnect2 plugin settings!
EDIT: Reviewing volspotconnect2/index.js, I found the following code, with some choice bits about initial volume control not being needed. For what it’s worth, it seems that hiding the element leads to initial volume being set to zero - which does in fact prevent it from working. I propose disabling this check - or at the very least, figuring out a better idea of when the circumstances appropriate to hiding it are (presumably where the entry would be irrelevant?) Either way, setting it to 0 seems like the wrong approach - is there a better “null” config option - maybe just "" ?
ControllerVolspotconnect.prototype.getUIConfig = function () {
var defer = libQ.defer();
const langCode = this.commandRouter.sharedVars.get('language_code');
this.commandRouter.i18nJson(path.join(__dirname, `/i18n/strings_${langCode}.json`),
path.join(__dirname, '/i18n/strings_en.json'),
path.join(__dirname, '/UIConfig.json'))
.then((uiconf) => {
// Do we still need the initial volume setting?
const mixname = this.commandRouter.sharedVars.get('alsa.outputdevicemixer');
logger.debug(`config <${mixname}>: toggling initvol/volume_ctrl`);
if ((mixname === '') || (mixname === 'None')) {
uiconf.sections[0].content[0].hidden = false;
uiconf.sections[0].content[6].hidden = false;
} else {
uiconf.sections[0].content[0].hidden = false; //true
uiconf.sections[0].content[6].hidden = false; //true
}
// Asking for trouble, map index to id?
uiconf.sections[0].content[0].config.bars[0].value = this.config.get('initvol');
uiconf.sections[0].content[1].value = this.config.get('normalvolume');
uiconf.sections[0].content[2].value.value = this.config.get('bitrate');
Original Post continues, no longer relevant probably, other than "where’s the code?"
From screenshots as well as browsing the code, it looks like there should be some fields there. I only noticed this because the initial volume is set to 0!
Is this an issue on my own system? A Volumio 3 plugin-update issue? And, should I be digging into this myself and submitting a pull request? Is the current version the master branch in volumio/volumio-plugins on github? (I don’t see updates since Oct 2020)
The generated volspotify.toml appears to have the expected fields generated, just not populated with anything due to the lack of UI.
(At the end, to aid in forum previews being relevant): Hey folks - my first post here, but I’m an intermediate old hat around FOSS projects; hoping to help!
| Software | Version | Notes |
|---|---|---|
| Volumio | 3.175 | Raspberry Pi 3B |
volspotconnect2 |
3.0.7 | per package.json
|